Page MenuHomePhabricator
Create Task
Maniphest T16020

API for Special:Unwatchedpages
Closed, ResolvedPublic
Actions

Description

The API should be able to list unwatched pages. The best way is probably to implement this as a parameter of list=allpages (apfilterwatched). In SQL, this should probably be done as a LEFT JOIN against the watchlist table, then looking for wl_title IS (NOT) NULL. We also might wanna add an option to disable this for large wikis (Special:Unwatchedpages is cached at enwiki), after discussing with people who know why it's cached.

Version: 1.13.x
Severity: enhancement

Details

Reference
bz14020

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:09 PM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz14020.
Catrope created this task.May 7 2008, 7:53 PM
• demon added a comment.Jul 16 2008, 1:22 PM

Created attachment 5075
Starting point for implementation

Doesn't quite work yet, but I'm unfamiliar with the API's code. Copied the filter-by-langlinks bit as a base for implementation.

Attached:

ApiFilterWatched.patch2 KBDownload

Catrope added a comment.Jul 16 2008, 3:48 PM

Committed a modified version of that patch in r37748. In case you're interested, I changed the following things:

  • The USE INDEX had to be adjusted to avoid SQL errors
  • Removed the page_is_redirect=0 and page_namespace <> NS_MEDIAWIKI conditions, as it's up to the client whether they even *want* all that (the apfilterredir and apnamespace parameters)
  • Moved the addTables() and addJoinConds() calls to a more generic place so they aren't duplicated
  • Used arrays instead of WHERE clauses with AND in them
  • Set a warning if $wgMiserMode is true or if the user doesn't have the 'unwatchedpages' right
  • Moved the global $wgUser, $wgMiserMode; statement down to where it's actually used
MER-C added a comment.Nov 6 2008, 4:35 AM

Reverted in r37775.

Catrope added a comment.Nov 6 2008, 1:38 PM

This'll be automatically fixed once someone fixes bug 14869.

Reedy added a comment.Mar 6 2010, 6:08 PM

Closing as "resolved/later"

Will be fixed by bug 14869, and makes the API bug list a bit clearer (as these are essentially duplicates)

Catrope added a comment.Dec 22 2010, 9:27 PM

(In reply to comment #5)

Closing as "resolved/later"

Will be fixed by bug 14869, and makes the API bug list a bit clearer (as these
are essentially duplicates)

Done now (branch merged in r78786).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL