Page MenuHomePhabricator

Extension Makebot is obsolete; should be removed
Closed, ResolvedPublic

Description

Extension Makebot is obsolete as its functionality is now available on WMF wikis through [[Special:Userrights]]. It should be removed from the configuration of all wikis.

The same could probably be true for Makesysop, although I do not know if 'make sysop' and 'desysop' are two separate configurable rights... (as sysops can be created by bureaucrats, and desysop can only be performed by stewards)


Version: unspecified
Severity: enhancement

Details

Reference
bz14156

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:11 PM
bzimport set Reference to bz14156.
bzimport added a subscriber: Unknown Object (MLST).

Aaron tell me the extension is needed for showing log items. Sounds like something that should be fixed in core...

Eugene.Zelenko wrote:

User rights and bot status logs should be combined before removing bot status/make sysop extensions.

Four calls like

$dbw->update(
'logging',
array(

		'log_type' => 'rights',
		'log_action' => 'rights',
		'log_params' => "\nbot" ),

array(

		'log_type' => 'makebot',
		'log_action' => 'grant' ),

'convertLogs.php' );

would do it, but it'll fail to take other permissions affected accounts had at that time. Though since some changes are on Meta, some older log entries have different format, and some rights were assigned before the introduction of logs, there probably can be no absolutely correct way to convert makebot logs.

Bryan.TongMinh wrote:

You will want to traverse the bot promotion log from top to bottom or from bottom to top to get effective summaries. In the meanwhile Special:Makebot could be disabled though.

Created attachment 5107
Maintenance script for conversion of makebot logs

Proposed conversion script, works with disclaimer from Comment #3.

Attached:

Do you take into account that, there are links to the old style logs in the wikis, including ones having varuious combinations of parameters?

mike.lifeguard+bugs wrote:

(In reply to comment #4)

You will want to traverse the bot promotion log from top to bottom or from
bottom to top to get effective summaries. In the meanwhile Special:Makebot
could be disabled though.

Yes, Special:Userrights should be used now. Makebot should be removed.

  • Bug 17272 has been marked as a duplicate of this bug. ***

Added a maintenance script to convert the logs in in r55219

The wikis that will need conversion (as of a few minutes ago) are: http://p.defau.lt/?8Omw64sUPLDuiohjiE8nlw

I wasn't able to check some of the "special" wikis due to either restricted access or API disabled

The alias of MakeBot had been set to UserRights by Mr. Z-man on r55660.

mike.lifeguard+bugs wrote:

(In reply to comment #11)

Disabled by Brion on 2009-09-21:
http://wikitech.wikimedia.org/index.php?title=Server_admin_log&diff=22557&oldid=22556

bug 20767 needs to be done before this is considered fixed.