Page MenuHomePhabricator

LanguageXx.php files contain WMF specific settings
Closed, ResolvedPublic

Assigned To
None
Authored By
siebrand
May 17 2008, 5:24 PM
Referenced Files
F4933: wgGrammarForms-rmy
Nov 21 2014, 10:12 PM
F4932: LanguageLv.php.patch
Nov 21 2014, 10:12 PM
F4931: wgGrammarForms-lv
Nov 21 2014, 10:12 PM
F4930: LanguageHu.php.patch
Nov 21 2014, 10:12 PM
F4929: wgGrammarForms-hu
Nov 21 2014, 10:12 PM
F4926: wgGrammarForms-gsw
Nov 21 2014, 10:12 PM
F4927: wgGrammarForms-ga
Nov 21 2014, 10:12 PM
F4928: LanguageGa.php.patch
Nov 21 2014, 10:12 PM

Description

13 LanguageXx.php files contain WMF specific settings that should be migrated to the Wikimedia configuration and taken out of the standard product. In all these cases, I am referring to conjugations of Wikimedia project names, that should end up in 'wgGrammarForms' in InitialiseSettings.php.

The following files contain settings that should be migrated to the local WMF configuration:

  • LanguageBe.php
  • LanguageBe_tarask.php
  • LanguageBs.php
  • LanguageCs.php
  • LanguageDsb.php
  • LanguageGa.php
  • LanguageGsw.php
  • LanguageHsb.php
  • LanguageHu.php
  • LanguageLv.php
  • LanguageRmy.php
  • LanguageSk.php
  • LanguageSl.php

Version: unspecified
Severity: enhancement

Details

Reference
bz14165

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:12 PM
bzimport set Reference to bz14165.
bzimport added a subscriber: Unknown Object (MLST).

LanguageCs.php solution in bug 14294.

  • LanguageBe.php
  • LanguageBe_tarask.php
  • LanguageBs.php

Solution for the above also in bug 14294.

  • LanguageDsb.php
  • LanguageHsb.php

Solution for the above also in bug 14294.

Created attachment 5146
wgGrammarForms for 'gsw'

After configuring this, LanguageGsw.php can be deleted. There is no longer added functionality.

Attached:

Created attachment 5147
wgGrammarForms for 'ga'

Attached:

Created attachment 5148
Cleanup for LanguageGa.php after wgGrammarForms for 'ga'

Attached:

Created attachment 5149
wgGrammarForms for 'hu'

Attached:

Created attachment 5150
Cleanup for LanguageHu.php after wgGrammarForms for 'hu'

Attached:

Created attachment 5151
wgGrammarForms for 'lv'

Attached:

Created attachment 5152
Cleanup for LanguageLv.php after wgGrammarForms for 'lv'

Attached:

Created attachment 5153
wgGrammarForms for 'rmy'

After configuring this, LanguageRmy.php can be deleted. There is no longer
added functionality.

Attached:

Brion suggested a different, probably better solution, that is also much easier for Wikimedia shell operators: add all this stuff to the extension WikimediaMessages, and as a consequence, remove the section 'wgGrammarForms' from http://noc.wikimedia.org/conf/InitialiseSettings.php.html.

I have already made all necessary changes to files on my local system. Will discuss this on IRC when brion, Tim, or JeLuF is available.

Fixed in r39077.

  • (bug 14165, bug 14294) Wikimedia specific configuration in convertGrammar() for 13 localisations (be, be-tarask, bs, cs, dsb, ga, gsw, hsb, hu, lv, rmy, sk, sl) removed. The settings have been put in extension WikimediaMessages. For be, be-tarask, bs, dsb, hsb some duplicates (1=1) were removed. Patch for Czech by Danny B.
  • Also put the wgGrammarForms from the Wikimedia configuration in here, so everything is in one place. Bonus with this setup is that there will be a little less work for Wikimedia shell operators, as the wgGrammarForms configuration is now accessible to i18n committers.
  • Header for WikimediaMessages.php, and add myself to extension credits.

WARNING to Wikimedia shell operators: the whole section "wgGrammarForms" in InitialiseSettings.php.html should be remove after updating to this version. It will most probably overrule all settings in WikimediaMessages because of "'default' => array()"