Page MenuHomePhabricator

Patch for generateSitemap.php
Closed, ResolvedPublic

Description

Author: dasch

Description:
Patch from 03.06.2008

Here will be some changes I made to my MediaWiki (wecowi.org)
Maybe something could be useful for MediaWiki Development
Only take a quick look, feedback or questions are welcome


Version: 1.12.x
Severity: enhancement

attachment 03.06.2008.patch ignored as obsolete

Details

Reference
bz14397

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:14 PM
bzimport set Reference to bz14397.
bzimport added a subscriber: Unknown Object (MLST).

dasch wrote:

Patch from 03.06.2008

Sry wrong file

attachment 03.06.2008.patch ignored as obsolete

What does your patch fix? Some description would be nice :)

Could you please provide a patch w/o the whitespace changes, it makes a review harder. Thanks a lot.

dasch wrote:

Version without spaces

maybe the sources should always be cleaned of space, like my editor do

Attached:

dasch wrote:

Sure I'll explain

  1. I made generate Sitemap work with the server option

it is used in the Sitemap Index an in the sitemaps, so for example for my wiki I generate the sitemap with another domain for each week

  1. Removed fixed sizes from editbuttons so that smaller version could be included through a gadget
  2. Made Option to disable ulimit.sh

On my Wiki it does not work with ulimit

Raimond, can you please review the patch and advise?

(In reply to comment #5)

Raimond, can you please review the patch and advise?

Sorry, but someone else should review.

What are the changes in main.css for? Are you certain this is a clean patch?

dasch wrote:

the changes in main.css are for displaying skype: links like irc: links

(In reply to comment #8)

the changes in main.css are for displaying skype: links like irc: links

Yes, obviously. But why would that be in a patch called "Patch for generateSitemap.php"? Can you please ensure to deliver a clean patch?

dasch wrote:

I don't know why this patch is named that way

Soembody changed it to that or the attaching of the diff file had changed the name

what does it mean a clean patch?

this was ment to be to but all changes for the Web Community Wiki together, to show what I've changed and then the developers could choose which of my changes are useful or not

(In reply to comment #10)

this was ment to be to but all changes for the Web Community Wiki together, to
show what I've changed and then the developers could choose which of my changes
are useful or not

Ah. That's a certain recipe for a patch to never be applied. You will have the highest succes rate submitting individual functionalities, fixes, or bugs in individual bugs.

Given your above explanation, I think this patch should be a WONTFIX.

dasch wrote:

okay, not my problem, just tried to show what I`ve changes, when there is nobody interested in it, then not

in my version there are these changes, so it's not for me

dasch wrote:

seams that I solved the problem that is given there, but nobody listens to my, not my problem

*** This bug has been marked as a duplicate of bug 9675 ***

dasch wrote:

*** Bug 14336 has been marked as a duplicate of this bug. ***