Page MenuHomePhabricator

accountcreator user right not bypassing account creation limit
Closed, ResolvedPublic

Description

Author: overlordq

Description:
According to the wiki SQL gave me the Account creator right earlier this morning[1]. Since then I've created 8 accounts[8]. However going through [[WP:ACC]] to process some of the requests I get the usual unexpected error: "Visitors to Wikipedia using your IP address have created 6 accounts in the last 24 hours, which is the maximum allowed in this time period. "

Which is strange since like I've mentioned I have created about 13 over the past 24 hours and not six, secondly shouldn't the accountcreator should be bypassing this restriction?

  1. http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=&user=&page=User%3AOverlordQ&year=&month=-1
  1. http://en.wikipedia.org/w/index.php?title=Special:Log&user=OverlordQ

Version: unspecified
Severity: normal

Details

Reference
bz14424

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:09 PM
bzimport set Reference to bz14424.
bzimport added a subscriber: Unknown Object (MLST).

Fixed in r35970.

A logic error was introduced in r35908, which added the 'noratelimit' user right to replace $wgRateLimitsExcludedGroups while attempting to retain compatibility with the old configuration. The wrong boolean operation was used, requiring _both_ settings to match to take effect.

I've changed the function to behave correctly and be a little clearer and more self-documenting.