Done in r36417

pbirken wrote:

Mh, what's the problem with the second option of showing the box?

pbirken wrote:

I though some more on this: the problem with this one is that then, people will get the one click sighting no matter what preference they chose and some people will not want this. Therefore, there should be the possivility in the flagged revisions preferences to turn one click sighting off.

pbirken wrote:

OK, so here is the final thought :-)

The combination of the preference "Do not show page content below diffs" with flagged revisions is rather unnatural. Instead, the following is much better: As default, enable one-click-sighting for editors. Add a preference in the flagged revisions section to disable that and furthermore, add a preference to disable the box for flagging completely.

This would mean that people could chose how much they want to get involved in the process of sighting edits: Only by an automatic process, a bit or a lot. And by chosing the default as the maximal involvement, I hope that we will get this to scale much better. Currently, you often have the situation that editors edit after a noneditor but do not sight the whole thing.

Further improve in r37649. Diff after edit suppresses the preference.

pbirken wrote:

It's still that way that if I enable Misc->Do not show page content below diffs, then one-click-sighting is disabled.

What diff links cause that? The flagged revs UI links should point to &diffonly=0, unless overridden locally, in which case Sysops should tweak the messages.

Looks like a local message issue. These should be updated.

Looks like a local message issue. These should be updated.

pbirken wrote:

Ah, I apparently wasn't thorough. Thanks for improving this a lot! The problem is still caused by difflinks like http://de.wikipedia.org/w/index.php?title=Millennium-Probleme&diff=48859429&oldid=48348473, where the box appears in the one case and doesn't in the other. What about the additional preferences I mentioned?

I don't want the preferences to start getting bloated here. I'd rather everyone have the box and diff.

As for the diff links that are not from the flaggedrevs UI, like the one above, I'd rather not change the behavior there, since it would be unexpectedly overriding the user's preferences.

pbirken wrote:

With the possibility of flagging templates, the chance of getting vandalism from "outside", meaning from templates or pictures is so small, that there's no real reason not to make one-click-sighting available to everybody. So, the solution would be not to show the whole article and the box in the diff above, but to show the box in both cases and the article only if set in the user's preferences.

Done in r39330