Page MenuHomePhabricator
Create Task
Maniphest T16652

Allow ZIP CAPAB on irc.wikimedia.org
Closed, DeclinedPublic
Actions

Description

CAPAB is an irc extension of ircd hybrid which allows to request a extension for a link. If either end don't support a capability (or CAPAB command at all) it is ignored. CAPABility ZIP allows for data compression (the server must be compiled with ZIP_LINKS).

Many uses of irc.wikimedia.org involve specific software, which are likely to add support for it (as opposed to normal irc clients), and given the amount of messages on that server, compression would make a difference on user bandwidth.

However, use of compression is not allowed for clients.

I'd have filled this bug time ago, but after querying about it, thought the code wasn't available any more. So _please_ put it on svn (either full or as a diff)

Version: unspecified
Severity: enhancement

Details

Reference
bz14652

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT18599 RecentChanges IRC related issues (tracking)
 DeclinedNoneT16652 Allow ZIP CAPAB on irc.wikimedia.org
 ResolvedNoneT44789 IRCD source code on Gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:10 PM
• bzimport added projects: Wikimedia-IRC-RC-Server, Upstream.
• bzimport set Reference to bz14652.
• bzimport added a subscriber: Unknown Object (MLST).
Platonides created this task.Jun 26 2008, 2:52 PM
siebrand added a comment.Aug 13 2008, 5:43 PM

Inspired by bug 14658, by the way.

siebrand added a comment.Aug 13 2008, 5:43 PM

Ignore comment 1, please. I thought I was typing on another report.

Platonides added a comment.Dec 29 2008, 6:56 PM

Add ZIP CAPAB for users to ircd-hybrid-6.4.4

Patch against ircd-hybrid-6.4.4 which adds the ZIP CAPAB to users.

Attached:

bug_14652.patch1 KBDownload

• bzimport added a comment.Mar 23 2009, 1:41 AM

mike.lifeguard+bugs wrote:

We have an 'IRC' component now.

• brion added a comment.May 28 2009, 7:08 PM

Here Fred, have a fun one. :) Not a high priority but might be nice to get off the list if it looks feasible.

• bzimport added a comment.Jun 16 2009, 8:12 PM

fvassard wrote:

ZIP CABAP has been enabled:

Compiling ircd-ratbox stable

Installing into: /usr/local/ircd-ratbox
Ziplinks ....................... yes
OpenSSL ........................ no
Modules ........................ shared
IPv6 support ................... no
Net I/O implementation ......... epoll
IO Debugging hooks ............. no
Assert debugging ............... no
Small network .................. no
ratbox-services compatibility .. yes

Resolving.

Platonides added a comment.Jun 22 2009, 11:58 PM

The enabled capability is for server<->server communication.
This bug is for clients to be able to receive the events compressed.

Peachey88 added a comment.Apr 30 2011, 12:09 AM

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

Dereckson added a comment.Dec 6 2012, 5:09 PM

I've opened bug 42789 to see if we can get the IRCD source code on a Gerrit repo to apply this patch.

hashar added a comment.Mar 16 2013, 8:49 PM

This patch is years old, maybe you should consider sending it to upstream http://www.ircd-hybrid.org/ . That might land on our servers via Ubuntu before we managed to apply the patch ourself :-]

Aklapper added a comment.Jul 25 2013, 6:15 PM

Platonides: Have you considered writing your patch against code of current trunk in http://svn.ircd-hybrid.org:8000/viewcvs.cgi/ircd-hybrid/trunk/ and upstreaming that patch? See comment 10.

I'd prefer to try that first (especially due to the reviewing expertise of upstream maintainers - I don't expect anybody of Wikimedia ops to know the IRCD code by heart) to maintaining local patches, at least as long as upstream has not rejected a patch *yet*. :)

hashar added a comment.Aug 26 2013, 1:41 PM

We use irc-ratbox. None of the irc server I am connected to seems to offer a ZIP capability.

I don't think we should maintain such a patch locally, it is much better to have it reviewed upstream and merged there for long term maintenance. That will benefit other users as well.

Given the capability is not that much of an issue for the server, I don't think we need to keep this bug report around.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL