Page MenuHomePhabricator

Googlepie: too few colors
Closed, DeclinedPublic

Description

Author: dasch

Description:
When using Google Pie with more then 10 entries the difference beetween the colors is too small


Version: unspecified
Severity: enhancement

Details

Reference
bz14761

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:10 PM
bzimport set Reference to bz14761.

dasch wrote:

do not like to post more bugs

but the googlebar does not show positiv and negativ values

for testing, I've many different data you are welcome try here (http://www.wecowi.com/view/WeCoWi:Spielwiese)

requests for testing special queries just use the discussion page

dasch wrote:

have I seen it right? the Google Chart Function was deleted? Why? Thats very sad

It now is in a separate extension. Contact Denny for details.

wsimpson wrote:

This patch adds an additional color (red) to the pie chart if there are more than 10 entries.

This patch simply checks the number of entries before returning the code for the chart. If there are more than 10 entries, it returns a yellow and red chart, otherwise it returns a yellow chart.

attachment SRF_GooglePie.php ignored as obsolete

wsimpson wrote:

This attachment adds an additional color (red) after 10 elements.

The previous patch contained an extraneous variable.

Attached:

dasch wrote:

well that looks better

check this page to see the result

http://www.wecowi.de/view/S%C3%BCdamerika

maybe it could be even done a bit better, I don't know what googlepie is able to do

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

Adding "need-review" keyword to indicate patch awaits review.

Aklapper subscribed.

The Semantic MediaWiki developers requested in https://phabricator.wikimedia.org/T64114 to move their task tracking to https://github.com/SemanticMediaWiki and to close remaining tasks in Wikimedia Phabricator. If you still face the problem reported in this task in a supported version of SMW, please feel free to transfer your report to https://github.com/SemanticMediaWiki/SemanticResultFormats/issues . We are sorry for the inconvenience.