Page MenuHomePhabricator

Disallow blocking when user is already in block list
Closed, ResolvedPublic

Description

Author: silsor

Description:
Please do not allow a block form to succeed when a user is already blocked.


Version: unspecified
Severity: enhancement

Details

Reference
bz1496
TitleReferenceAuthorSource BranchDest Branch
Finish conversions for pyflink and python native typesrepos/data-engineering/eventutilities-python!85ottopyflink_python_conversionmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 8:13 PM
bzimport set Reference to bz1496.
bzimport added a subscriber: Unknown Object (MLST).

Disallowing it is not a good idea, because one may need to extend the block
period and/or change the reason for blocking the user for the records. But I
belive showing a message on the confirmation page that informs the admin that
the user is already blocked (and by whome, until when, for what reason) would be
very helpful.

See also the related bug #2044.

p_simoons wrote:

Showing a warning "this user is already blocked until <time>" would be very useful.

koneko wrote:

Disallowing it is not a good idea, because one may need to extend the block
period and/or change the reason for blocking the user for the records.

if he tries to expend the block period without deleting the other block, the
first block ending will delete all the others.

but well, I agree with the general idea, it's such a bother to have 3 or 4 times
the same name on the ipblocklist

robchur wrote:

I would suggest having the block form do a quick check to see if a block is
effective, and if so, return a quick confirmation - "User Foo blocked this
user/IP on XXX with the reason YYY" - clicking Block again would confirm the block.

If no sizeable objections raise their heads by the time I get round to it, I'll
implement this. Ideas? Feedback? Let's have it.

mediawikibugs wrote:

(In reply to comment #4)

I would suggest having the block form do a quick check to see if a block is
effective, and if so, return a quick confirmation - "User Foo blocked this
user/IP on XXX with the reason YYY" - clicking Block again would confirm the

block.

If no sizeable objections raise their heads by the time I get round to it, I'll
implement this. Ideas? Feedback? Let's have it.

Sounds like a good idea to me.

le.korrigan wrote:

Yes, sounds very good, it has been discussed on fr.wikipedia admins' blog today
after a user was blocked 4 times in a row. Full support from me, I don't see any
drawbacks to this.

For IPs, how should we handle conflicting autoblocks?

wartdark wrote:

After many mistakes, I support the idea of a request for confirmation to any
blocking (IPs or recorded users) like Korrigan.

This was fixed a while back by Tim Starling in his blocking changes.