Page MenuHomePhabricator

Arrows pointing to sections in page histories don't work due to changes in Linker class
Closed, ResolvedPublic

Description

Author: titoxd.wikimedia

Description:
The "→" arrows that serve as anchors for sections edited using section editing (pardon the redundant redundancy) changed behavior after the latest scap. Now, instead of anchoring to a particular section, they point to the top of the page; that is, they don't append #{{SECTIONTITLE}} as they used to do.

Occurs on [[Special:RecentChanges]], [[Special:Contributions]] and article histories WikiMedia-wide. The →'s in diffs now only point to "http://en.wikipedia.org/wiki/", without even appending the page title.


Version: 1.14.x
Severity: normal
URL: http://en.wikipedia.org/wiki/Special:RecentChanges

Details

Reference
bz14995

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:13 PM
bzimport set Reference to bz14995.
bzimport added a subscriber: Unknown Object (MLST).

titoxd.wikimedia wrote:

*** Bug 14996 has been marked as a duplicate of this bug. ***

ayg wrote:

This is probably my fault. Looking into it.

bug 14997 seems to have been caused by the same revision (r38254)

ayg wrote:

Fixed in r38325. Looking at bug 14997 now.

khriseagle wrote:

Reopening. Mostly fixed, but there's still a problem with links from diffs: they now point to http://en.wikipedia.org/wiki/#Section.

ayg wrote:

(In reply to comment #7)

Still not working correctly, it doesn't seem to be encoding the section name in
the links,

Rotem fixed this in r38356.

(In reply to comment #8)

Links from diffs are broken again: they're now linking to the diff itself:
e.g. section edit link from
http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=229221105&oldid=229218798
points to
http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&diff=229221105&oldid=229218798#Section%20link%20in%20edit%20summary%20broken

It's done that for a long time, if you show the revision content below the diff. It seems to be behaving correctly except that the fragment is wrong due to not being escaped right, which is now fixed. Marking FIXED again.

ayg wrote:

*** Bug 15001 has been marked as a duplicate of this bug. ***