Page MenuHomePhabricator

Don't show diff on edit page if user can't review changes
Closed, ResolvedPublic

Description

Proposed patch

Diffs on edit page which shows changes between the last reviewed and actual version are pointless for non-reviewers, since such users can't review them anyway and they usually have a large size even for small diffs (which can be significant on large articles; note that it was a real complain from dial-up user).


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz15062

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15062.

The main point is to explain the discrepancies between the version they saw (stable) and the text they see when they click 'edit'.

Wiki.Melancholie wrote:

@aaron: This only applied for the old configuration on de. With the current configuration the user sees the draft version by default. Even then he/she will get a diff on edit.

Show diffs only if user came from stable=1, I would say.

Wiki.Melancholie wrote:

@vasilvv: Note that the address http://de.wikipedia.org/w/index.php?title=L%C3%A4ssig&stable=1 is likely to be linked from outside, so diffs should still occur if a user/IP edits a page from stable=1 as starting point (if latest rev isn't flagged).

Fixed in r38757 per comment #2