Page MenuHomePhabricator

prop=categories returns timestamps that are not in ISO 8601 format
Closed, ResolvedPublic

Description

format as ISO 8601 cl_timestamp before adding it to the array (patch against trunk)

ENV: bug tested on commons which says it's running 1.14 alpha (r40071)

prop=categories returns timestamps that are not in ISO 8601 format

I combed through gfind -name .svn -type d -prune -o -iname \*api\* -type f -exec grep -in -25 "timestamp" {} + and the only place I could find that returns a timestamp not in ISO 8601 format is fixed in the attached patch.

Of course, there could be cases that don't use the token 'timestamp' in or near the assignment or I could have missed one. (I'm not terribly well versed in MW code)

The patch has not yet been tested.


Version: 1.14.x
Severity: normal
URL: http://commons.wikimedia.org/w/api.php?format=xml&action=query&prop=categories&clprop=timestamp&titles=Image:Hrad_Oko%C5%99.jpg

Attached:

Details

Reference
bz15348

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:18 PM
bzimport set Reference to bz15348.

Applied in r40161 and r40162.

WFM after checkin and sync.

Thanks.