Page MenuHomePhabricator

Edit summaries with multiple section links (/*sections*/) only parse the final section link correctly
Closed, ResolvedPublic

Description

Author: oranl

Description:
Where: Anywhere an edit summary can be displayed: history page, compare diffs pages, watchlist.

What: When the software displays an edit summary that contains more than one section link (e.g.: "/*Heading 1*/ Copyedit /*Heading 2*/ Fix link"), only the last section link will be properly parsed (the above example would be displayed like this: "/*Heading 1*/ Copyedit - → Heading 2: Fix link").

Expected: All section links should be parsed correctly to contain a link to the edited section and display the section name in gray-colored font.

Steps to Reproduce:

  • Open the edit page window on a MediaWiki project
  • Make an edit to two different sections
  • In the edit summary, type: "/*SectionOne*/ Edits made /*SectionTwo*/ Edits made", where SectionOne and SectionTwo are the section names you edited
  • Save the page
  • Observe the page history (only SectionTwo is properly parsed)
  • Compare the version you just saved with any other version of the page
  • Observe the edit summary in the compare diffs page (only SectionTwo is properly parsed)

Additional Information: This used to work properly. User:Alex Smotrov at en.wikipedia.org suggested that this revision may be part of the issue: http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=39373
Please also see a sandbox edit on en.wikipedia.org for an example of this issue: http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=prev&oldid=235880025


Version: 1.14.x
Severity: major

Details

Reference
bz15481

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15481.
bzimport added a subscriber: Unknown Object (MLST).

alexsm333 wrote:

Another issue that might be related:

<Words> between angle brackets disappear from edit summary, resulting in incorrect section links.

Example diff: http://en.wikipedia.org/w/index.php?diff=prev&oldid=236108247

oranl wrote:

This is still happening in MediaWiki 1.15alpha (r48811). See the bug description for a link to an example of this bug in action. Here's a more recent example: http://en.wikipedia.org/w/index.php?title=Rick_Berman&diff=283163141&oldid=282764719.

  • This bug has been marked as a duplicate of bug 16530 ***