Page MenuHomePhabricator

Don't report changes to wikibugs-l when only the CC changes
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
When only the CC changes, there's probably no need to have that reported to wikibugs-l.


Version: unspecified
Severity: enhancement

Details

Reference
bz15585

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15585.

bugs wrote:

(In reply to comment #0)

When only the CC changes, there's probably no need to have that reported to
wikibugs-l.

I have no problem with this and after all... we get reports to wikibugs-l because we're watching "all bug changes". If we remove the CC part, that's different.

wikibugs-l itself is set not to receive CC-only changes for bugs it's assigned or CC'd to, but it's on 'globalwatchers' to receive *all* notifications, which doesn't seem to include an option to exclude them. May need to patch bugzilla to do this.

Ok I'm testing a tweak for this. This item should show up since it has a comment.

Created attachment 5575
Patch to Bugzilla/BugMail.pm to hack this

Marks globalwatchers internally as if they were CCs, so the email preferences on the user account will be taken into account, since there is no pref column for globalwatchers (https://bugzilla.mozilla.org/show_bug.cgi?id=365303)

Attached:

Seems to be doing the job. Yay!

Just adding 'upstream' keyword for future reference.

overlordq wrote:

Appears after the BZ update, CC-only changes are being sent to the mailing list again and thus in the related bug 10842 being spamming by wikibugs in MediaWiki-General

Be nice to get this redisabled.

Checked in a patched version to /trunk/tools/Bugzilla-3.4.4 in r62556. Needs sync'ing to the live Bugzilla install.

Priyanka sync'd the fix, seems to be working now. Resolving FIXED (again)

CC's only reported on IRC again. Obviously after upgrade to BZ4. Reopening.

Reclosing, we already have 28402 open for this.