Page MenuHomePhabricator

Diff after rollback in the majority of cases not shown
Closed, ResolvedPublic

Description

Normally a diff of a rollbacked edit is shown on the rollback result page.

But on Wikimedia projects the diff is in the majority of cases not shown. Only sometimes :-/

The HTML source contains an empty table instead:

		<table class='diff'>
		<col class='diff-marker' />
		<col class='diff-content' />
		<col class='diff-marker' />
		<col class='diff-content' />
		<tr valign='top'>

		<td colspan='2' class='diff-otitle'></td>
		<td colspan='2' class='diff-ntitle'></td>
		</tr>
		<!-- diff generator: wikidiff2 srv110 2008-09-20 22:01:18 -->

and same

		<!-- diff generator: wikidiff2 srv173 2008-09-21 11:56:56 -->

A diff was shown from srv155:

<!-- diff generator: wikidiff2 srv155 2008-09-19 19:14:56 -->
<!-- diff cache key dewiki:diff:version:1.11a:oldid:48233907:newid:50914488 -->

I am unsure if it is an issue with MediaWiki code or settings of the servers.


Version: unspecified
Severity: normal

Details

Reference
bz15672

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:19 PM
bzimport set Reference to bz15672.
bzimport added a subscriber: Unknown Object (MLST).

Codeispoetry spotted another server who gave a diff after rollback:

<!-- diff generator: wikidiff2 srv135 2008-09-23 15:49:52 -->

getNextRevisionID() uses a slave (occasionally the master) to find the 'next' revision for the diff

(In reply to comment #2)

getNextRevisionID() uses a slave (occasionally the master) to find the 'next'
revision for the diff

Should be fixed in r41198