Page MenuHomePhabricator

Handling of unknown parameters while expanding using PPCustomFrame's
Closed, ResolvedPublic

Description

Author: bugs

Description:
Proposed patch.

In PPCustomFrame_DOM and PPCustomFrame_Hash, no checking is performed in getArgument() when arguments not contained in frames are requested, causing PHP undefined variable error messages. This happens while expanding templates using a custom frame.

A simple check is needed using isset(), just like those found in PPFrame_* and PPTemplateFrame_*.

Patch to fix this problem is attached.


Version: 1.14.x
Severity: normal

Attached:

Details

Reference
bz15737

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:23 PM
bzimport set Reference to bz15737.
bzimport added a subscriber: Unknown Object (MLST).