Page MenuHomePhabricator
Create Task
Maniphest T17739

change showcurid to show wiki url as oposed to /w/index.php...
Closed, ResolvedPublic
Actions

Description

Currently, when using showcurid=true in a DPL, it gives urls like:
http://en.wikinews.org/w/index.php?title=CanadaVOTES:_Libertarian_Kevin_Stricker_running_in_Saskatoon%E2%80%94Rosetown%E2%80%94Biggar&curid=113852

Well this is essentially what we (wikinews) need for google news, there is a problem. The googlebot i believe is prevented via robots.txt from browsing w/index.php... pages.

Would it be possible to make showcurid=true use urls like
http://en.wikinews.org/wiki/CanadaVOTES:_Libertarian_Kevin_Stricker_running_in_Saskatoon%E2%80%94Rosetown%E2%80%94Biggar?curid=113852
instead?

Thanks, Bawolff

p.s. Bastique told me to assign this to Aaron. I've never actually assigned a bug to anybody when entering it, so i hope i did that right. sorry, if i messed that up and it causes any confusion.

Version: unspecified
Severity: enhancement

Details

Reference
bz15739

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:23 PM
• bzimport added projects: DynamicPageList (Wikimedia), Shell.
• bzimport set Reference to bz15739.
Bawolff created this task.Sep 27 2008, 2:19 AM
• bzimport added a comment.Sep 27 2008, 9:50 AM

mattj wrote:

Feature added in r41301, needs to be enabled by a shell once scapped.

• bzimport added a comment.Sep 28 2008, 11:02 PM

mattj wrote:

According to Special:Version this should be active, so just waiting on a shell to add the config setting.

• brion added a comment.Sep 29 2008, 10:54 PM

That code looks pretty ugly to me. It's not clearly self-documenting (in getLocalUrl()'s code) and the option is wayyyyyy too specific to seem reasonable.

I recommend backing this change out. A more suitable "temporary hack" would be to just change DynamicPageList to slap that specific option on after the regular URL.

• brion added a comment.Sep 29 2008, 11:03 PM

Reverted r41301 and r41332 in r41402.

• bzimport added a comment.Sep 30 2008, 2:03 AM

mattj wrote:

Should be re-added in r41410 and r41411.

• brion added a comment.Oct 1 2008, 9:36 PM

I ended up reverting that in r41507 due to some interwiki breakage.

aaron added a comment.Oct 5 2008, 12:46 AM

Done in r41573, r41411

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL