Page MenuHomePhabricator

Improvement of handling of changed Commons images
Closed, ResolvedPublic

Description

Author: pbirken

Description:
The current behavior, that new versions of images on commons make versions appear as unsighted does not scale, since for some images (flags, placeholder images, etc.) this makes it necessary to flag thousands of pages on several projects.

Therefore, I think that new versions on commons should not make pages appear as unsighted. As a quick fix, a new message could be shown in the diff that tells people that the reason for the behavior is an image changed on commons. The current messages are very confusing and make people think this is a bug.


Version: unspecified
Severity: enhancement

Details

Reference
bz15748

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:17 PM
bzimport set Reference to bz15748.

Treating different versions (due to images) as synced seems like incorrect behavoir. Perhaps some way to get these images sighted might be better.

pbirken wrote:

Yes, but it is incorrect behavior that was deemed acceptable (in particular in light of the alternative as it is now) from the beginning by both Erik and me: We said to just ignore Commons. After seeing the confused reactions on de-WP I still say: As long as the change of an image on commons causes this much work on all projects with flagged revs, just turn that part off.

Seems not be fixed (all timestampes are CET):

Message above this diff: "Some templates/images were updated: Bild:Ali As - YOU 2008 Berlin (6681).JPG" but this image is still on Commons.

Did you purge the cache and diff?

Actually, this isn't really a bug. It still shows template changes on the diff, but what it shouldn't do is have the two draft and stable tabs.

(In reply to comment #5)

Did you purge the cache and diff?

No. Should I? I was glad to find a clear case of this bug/feature :)

(In reply to comment #7)

(In reply to comment #5)

Did you purge the cache and diff?

No. Should I? I was glad to find a clear case of this bug/feature :)

No, see comment #6. Purging should not do anything. This is more of a feature.

This is back again. The sync check still needs a rewrite (which should cover this and 23415)

Commons files except from sync check in r68135.