Page MenuHomePhabricator

Cite error: Invalid <ref> tag; refs with no name must have content
Closed, ResolvedPublic

Description

Author: sharon.dagan

Description:
Hello,

Using {{#tag:ref|name=something}} to produce a <ref> doesn't work.

I think that the root cause of this problem is that Cite thinks the
following code is invalid:

<ref name="something"></ref>

Unfortunately, this is the code that {{#tag}} produces.

See test case here:
http://en.wikipedia.org/wiki/User:TiredJoe


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/wiki/User:TiredJoe

Details

Reference
bz15770

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:18 PM
bzimport added a project: Cite.
bzimport set Reference to bz15770.
bzimport added a subscriber: Unknown Object (MLST).

skizzerz wrote:

Proposed patch to Cite_body.php

Added a proposed patch that ''might'' fix this issue. I have not yet tested it out (will do that tomorrow if nobody else does), so I'm not sure if anything else needs changing as well

Attached:

ssanbeg wrote:

fixed in r41512, but a little more strict than the patch; it should allow <ref name=whatever></ref>, but give the error for <ref></ref>.

  • Bug 11814 has been marked as a duplicate of this bug. ***

ayg wrote:

(In reply to comment #3)

Comment on commit, see
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/41512. REOPENED.

Was fixed in r41669, reclosing. (Didn't affect the correctness of the fix anyway.)

ncw33 wrote:

*** Bug 14190 has been marked as a duplicate of this bug. ***