Page MenuHomePhabricator

global block log broken in the recent changes
Closed, ResolvedPublic

Description

Author: spacebirdy

Description:
The global block log breaks if there is more than one action a day and if one has the enhanced rc activated.

it looks like

> 18:23 [Someone (2x)]

instead of

> 18:23 ([[m:Special:Log/gblblock|Global block log]])‎ [Someone (2x)]

Thanks in advance for Your help.


Version: unspecified
Severity: normal
URL: http://meta.wikimedia.org/wiki/Special:RecentChanges

Details

Reference
bz15798

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport added a project: GlobalBlocking.
bzimport set Reference to bz15798.
bzimport added a subscriber: Unknown Object (MLST).

spacebirdy wrote:

Also the global rights log.

Just seein this in the rc:

+- 02:17 ‎ [Someone; Someone else (2×)]

instead of

+- 02:17 ‎ (Global rights log) [Someone; Someone else (2×)]

Hmm.. both global blocks and global rights are my inventions. Did I miss something in creating a new log type?

spacebirdy wrote:

*** Bug 15987 has been marked as a duplicate of this bug. ***

mike.lifeguard+bugs wrote:

(In reply to comment #2)

Hmm.. both global blocks and global rights are my inventions. Did I miss
something in creating a new log type?

I think the logs themselves are fine, just the line you see in RC.

Okay, the problem with global blocking (haven't looked into global rights, probably the same thing) is that its setting the wrong combination of namespace and title in the recentchanges table:

mysql> SELECT rc_namespace,rc_title,rc_log_type FROM recentchanges WHERE rc_type = 3 ORDER BY rc_id DESC LIMIT 3;
+--------------+-------------------------------+-------------+

rc_namespacerc_titlerc_log_type

+--------------+-------------------------------+-------------+

2123.123.123.123block
-1Contributions/125.125.125.126gblblock
-1Contributions/125.125.125.125gblblock

+--------------+-------------------------------+-------------+

When the enhanced RC sees something in the special namespace, it assumes its going to be in the format of 'Log/type', and anything else just sets an empty string (includes/Changeslist.php Lines 431-440)

The fix would be to set the namespace to 2 like normal blocking and the title to just the username/IP address. Hopefully it can be done without breaking existing log entries.

mike.lifeguard+bugs wrote:

(In reply to comment #1)

Also the global rights log.

Just seein this in the rc:

+- 02:17 ‎ [Someone; Someone else (2×)]

instead of

+- 02:17 ‎ (Global rights log) [Someone; Someone else (2×)]

With enhanced RC, I see:
+- 21:58 (Global block log)‎ . . [Mike.lifeguard‎; Spacebirdy‎ (2×); Drini‎ (3×); Dungodung‎ (4×); Mardetanha‎ (6×)]

So... I guess this got fixed at some point, possibly r48005?

mike.lifeguard+bugs wrote:

to test bug 18054

mike.lifeguard+bugs wrote:

and now wikibugs should tell me it's changed to fixed...