Created attachment 6266
Detect requests for a history feed of a non-existant article

If the article does not exist, the fetchRevisions() function blindly passes the $this->mTitle->getArticleID() (which is zero), to the query, returning all revisions with rev_page=0.

I guess there should be none, anyway, but 1. there is no point in doing that, 2. it seems that on Wikimedia servers, there are some (see the abovementioned URL).

Either way, there is some code already that copes with an empty feed, so just be checking for a nonexisting page, we begin using that.

The resulting feed is not perfect, though.

attachment PageHistory.php.diff ignored as obsolete

Fixed in r59730.

Reverted myself in r59737.

sumanah wrote:

Alan, is this problem still happening? Can you still reproduce it?

Mormegil, as you can see in the comments for https://www.mediawiki.org/wiki/Special:Code/MediaWiki/59730 and https://www.mediawiki.org/wiki/Special:Code/MediaWiki/59737 , Chad originally committed your patch, but had to revert it because it caused some warnings, as well as a possible regression. Now, the codebase has changed enough that your patch doesn't apply cleanly to trunk anymore. I'm sorry.

If you have the time and the interest to update and revise your patch, please do! Thanks for the contribution.

sumanah wrote:

Comment on attachment 6266
Detect requests for a history feed of a non-existant article

Patch is obsolete and no longer applies cleanly against trunk, per
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html
automated testing.

chaos wrote:

Sumana, yes, I'm still seeing it. I've seen spurious updates go by as recently as November 11th, 2011. Two of the original examples I gave still have spurious updates (the last has since become a "real" page):

http://en.wikipedia.org/w/index.php?title=Image:Madison_Wisconsin_Flag.svg&feed=rss&action=history

• http://en.wikipedia.org/w/index.php?title=Olitext&feed=atom&action=history

A few other pages that I saw go by in my RSS aggregator recently:

• http://en.wikipedia.org/w/index.php?title=User:Alan_De_Smet%2FGoOFF&feed=atom&action=history
• http://en.wikipedia.org/w/index.php?title=Xlear_Nasal_Wash&feed=atom&action=history
• http://en.wikipedia.org/w/index.php?title=Image_talk:Aaron_Williams_of_Nodwick_at_Gen_Con.jpg&feed=atom&action=history

Created attachment 9598
Updated patch

(In reply to comment #4)

If you have the time and the interest to update and revise your patch, please
do!

The reasoning behind is bascially still the same – the only thing that changed is that fetchRevisions() now returns a ResultWrapper instead of a simple array (and performs “->numRows()” on it), so we need to return that. (There were more possible solutions here, I chose the simplest one.)

Attached:

sumanah wrote:

Mormegil, thanks for the update. I suggest you submit it directly into Git, our
source control system. You can do that with developer access:
https://www.mediawiki.org/wiki/Developer_access That way it'll get reviewed faster.

Thanks!

Patch committed with Gerrit change #10752 and successfully merged.