Page MenuHomePhabricator

problems getting thumbnails with chopped ogg streams
Closed, ResolvedPublic

Description

Author: mdale

Description:
re-tires to generate thumbnail on failure

Problem: segments of ogg streams do not upload well with oggHandler. No image thumbnail is generated and the pear File_Ogg script gives bad stream length. (Bad length messes up play head control for java-cortado playback)

~the quick hack patch is attached~
on failure to generate thumbnail we try to generate on the first frame and with "one off" stream mappings.

~ the solution ~
The PEAR File_Ogg script does not handle chopped streams very well. In addition to _lastGranulePos we need to read the _firstGranulePos so that we can get the base offset time. We can then subtract that from the _lastGranulePos frame time to get the proper duration.

The ffmpeg script on failure should read the stream mappings output and look for "theora" stream and call thumbnail generation for that stream. (this is also relevant if people start to upload ogg files with accessibility options like annodex timed text cmml muxed in) its possible that with a different thumbnail generator ie gstreamer or mplayer would be smarter about that and search for a video stream to grab the thumbnail.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz15920

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:21 PM
bzimport set Reference to bz15920.

mdale wrote:

This bug should be bumped up.. archive.org is now running oggz_chop as well..

so grabbing a chunk from archive.org say 10 seconds from night_of_the_living_dead on archive.org:
http://ia331342.us.archive.org/2/items/night_of_the_living_dead/night_of_the_living_dead.ogv?t=0:20:00/0:20:10
will work.
ie http://en.wikipedia.org/wiki/Image:Oggz_chop_test.ogg

since this patch has already been applied its probably an issue with the version of ffmpeg on the server.. if we could bump that version per the default version in the ubuntu repository it should hopefully fix the issue. I am running r11872+debian_3:0.svn20080206-12ubuntu3 locally and the stream mapping check works there.

Also if we could look at re-enabling get-via-url that would make it even easier to pull segments oggz_chop repositories (like archive.org and metavid.org)

peace,
--michael

Applied the patch, but we probably need a newer ffmpeg to make it actually work.

Marking this one fixed; ffmpeg version issue is bug 16167.