Page MenuHomePhabricator

Tidy replaces tabs with spaces
Closed, ResolvedPublic

Description

Tidy replaces tabs with spaces and per documentation http://tidy.sourceforge.net/docs/quickref.html#tab-size it never outputs tabs.

However it passes through 	 entity.

Thus all tabs in wikitext source between <pre></pre> and <source></source> should be replaced by the entity before passing to Tidy.


Version: 1.14.x
Severity: normal
URL: http://test.wikipedia.org/wiki/Tabs

Details

Reference
bz15959

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:16 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz15959.
bzimport added a subscriber: Unknown Object (MLST).

We could do str_replace from literal tab to &#9; and back in the wrappers around tidy calls. This would transform anything that was already using the numeric entity to a literal tab, but I think our Sanitizer would already do this, and it should be harmless.

r42257 has been reverted. Reopening.

ayg wrote:

Specifically because the fix caused other, more severe bugs. The real solution here is to get rid of Tidy.

Izno claimed this task.
Izno subscribed.

Looks like Remex fixed this.