Page MenuHomePhabricator

userWasLastToEdit function's revisions limit shouldn't be hard-coded
Closed, DeclinedPublic

Description

Author: nsk

Description:
r42034 added the userWasLastToEdit function in trunk/phase3/includes/EditPage.php (revision 42034), with a hard-coded revisions limit of 20:

+ * Check if no edits were made by other users since
+ * the time a user started editing the page. Limit to
+ * 20 revisions for the sake of sanity.
+ */
+ protected function userWasLastToEdit( $id, $edittime ) {
[...]
+ array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 20 ) );

I would like that revisions limit, which is currently hard-coded to 20, to become customisable to better suit wikis with different edit cultures.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz15991

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:18 PM
bzimport set Reference to bz15991.
bzimport added a subscriber: Unknown Object (MLST).

Limit bumped to 50. This is there for performance only, and it just a maximum plausible value. No need for a new config variable.