Page MenuHomePhabricator

Massive diffs should be hidden until user confirms they want it loaded
Closed, DeclinedPublic

Description

Author: mike.lifeguard+bugs

Description:
When the diff is /massive/ (ie the bottle table - not sure what a good size here would be) omit the diff until the user confirms they want it (perhaps load the diff w/ AJAX) This should apply to everywhere you see diffs. The main challenge, I imagine, will be figuring out before render how big the diff will be. Even if the server must render the diff, it will be worth not sending it along to the user unless they want it. Most such diffs are likely clear vandalism, and nobody will care to see such diffs. The remainder of actually-should-be-seen diffs can still be seen after confirming. This will help keep users' browsers from crashing after rollback of such vandalism, and inadvertently requesting diffs which are huge. A simple "This diff is X KB, and might crash or bog down your browser, do you really want to see it?" will be lovely.


Version: unspecified
Severity: enhancement

Details

Reference
bz16000

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:19 PM
bzimport set Reference to bz16000.
bzimport added a subscriber: Unknown Object (MLST).

Seems like an extra step without any real benefit.

  1. Select two revs on a page
  2. Press "Compare selected version" Diff is over X bytes, are you really sure you want to view it?
  3. Press ok.

Seems like it might bug a lot of users, and I'm hesitant to throw a new userpref in for this.

Changing to RESOLVED WONTFIX per Chad.