Fixed in r43650

mike.lifeguard+bugs wrote:

(In reply to comment #1)

Fixed in r43650

Does that also fix the inability to patrol new pages for wikis with FlaggedRevs which previously had new page patrolling (but not patrolling on every diff)?

Wiki.Melancholie wrote:

(In reply to comment #2)

(In reply to comment #1)

Fixed in r43650

Does that also fix the inability to patrol new pages for wikis with FlaggedRevs
which previously had new page patrolling (but not patrolling on every diff)?

This open question, plus: Will auto-patrolling for patrollers be re-enabled with this too?

Currently, changes - even done by SysOps - suddenly are marked in RecentChanges with <span class="unpatrolled">!</span> (red) if the page/article is not yet flagged. Actually there should be another exclamation mark for FlaggedRevs (<span class="unflagged">!</span>), let's say orange coloured (or .unflagged red but .unpatrolled orange); it just should have a different CSS class to properly differentiate FlaggedRevs stuff from Patroller stuff.

Wiki.Melancholie wrote:

Not sure whether it will be fixed when code is finally live, some day, but:
http://de.wiktionary.org/wiki/Spezial:Logbuch/patrol sometimes shows some automatically patrolled entries; but only those of certain users (only sporadically, without r43650 being live). I am wondering why this happens, as either no pages/edits should be patrolled actually (buggy state; this) or all (fixed state; r43650)! Most changes are not listed as patrolled there anymore (what probably was this bug).

Wiki.Melancholie wrote:

REOPEN, as all other namespaces still are not patrollable anymore (although r44485 is live).

Please see comments above, especially comment #4.

The option to auto-patrol own edits is missing in Special:Preferences (sysop, even when sighter status got removed)!
Even if not being a sighter, but patroller (sysop), no red exclamation marks are shown anymore (no rcid).

Fixed in r44489. Not too interested in the other stuff.

Wiki.Melancholie wrote:

Now the red exclamation marks do appear again for non-content namespaces :-)
But patrolling doesn't work properly!

But:
The patrol link is different from the former one. Now it is over all other comparison stuff (in the middle). Before FlaggedRevs it had been in the right column (near undo/rollback). Is this part of FlaggedRevs? Probably yes, as *all* sighters now have this link, not just sysops like before. OK, that is not the actual problem ;-) The actual problem is that the link does not have any effect for me (sighter+sysop)!

See http://de.wiktionary.org/w/index.php?title=Wiktionary:Teestube&curid=67156&diff=898366&oldid=898298&rcid=915951

When clicking on the link it will take me to the "successfully patrolled" page, but the red exclamation mark just doesn't disappear from RecentChanges! Furthermore, [[wikt:de:Special:Log/patrol]] doesn't show any patrolling of that. I still believe that comment #4 is important!

Fixed in r44552. RC interfaces were refactored a while a back and broke this. Using the more direct functions now.

Wiki.Melancholie wrote:

Fast ;-)
Thanks a lot :-)

Just to give you some more information, as I am wondering why also this bug was different for each user:

Further note that a user (just being sighter) mentioned that he saw red exclamation marks before the "Wiktionary:Teestube" at 22:18 (13th), but I didn't see those at that time, only one of an IP edit that was done at 00:30 (14th Dec.) [note that the other user now also just sees the red mark only for the latest change]. But the older changes actually weren't patrolled (seems to), see [[wikt:de:Special:Log/patrol]]. Related to comment #4? >>> For some users it seemed to work a little bit better, sometimes.(this is what I am still wondering about)

Perhaps it was just not logged or something?

Wiki.Melancholie wrote:

Might be so, but I the red exclamation mark also disappeared for the (latest) IP edit(s) when a sighter edited the page afterwards (did test this)!

Wiki.Melancholie wrote:

I think the issue of comment #11 has yet to be fixed also.?
Wrong behaviour of auto-patrolling?