Page MenuHomePhabricator

"nominornewtalk" should not trigger e-mail notifications
Closed, ResolvedPublic

Description

This seems to be a minor annoyance. If an automated task is run that contains a list of a bunch of user talk pages, the yellow notification bar will not trigger, yet an e-mail will still be sent should that person have that option set in their preferences. This user right should also incorporate suppressing e-mail notifications in addition to suppressing the yellow notification bar.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz16429

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:26 PM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz16429.
bzimport added a subscriber: Unknown Object (MLST).

To clarify:

'nominornewtalk' is a right key which is by default given to the 'bot' group. When a user with this right (a bot) *makes* a minor edit to a user talk page, the system *doesn't* trigger a "new messages" update for the owner of the talk page. This check is done in Article::editUpdates().

The bug request is to apply this same check to the e-mail notifications in UserMailer. Roughly speaking -- when we're adding a user to the notification list because he's the owner of the user talk page and wants to receive e-mail notifications for updates to his talk page, we should *not* add him if it's a minor edit and the *user making the edit* has 'nominornewtalk' right.

Note this will disable e-mail notifications of bots edits for all pages, not just user talk pages. I'm uncertain whether this should be the case; if the watcher has the 'enotifminoredits' preference will he expect to get notified anyway? Or should we consider this equivalent to bot edits in RC, being hidden?

(Of course, you can choose to show bot edits in RC... but here you wouldn't be able to ask for bot edit notifications without add'l changes.)

Probably not doing the notifications is the expected thing in most cases, but figured I'd add a note in case we decide otherwise. :D