Page MenuHomePhabricator

Special page hooks stop working for Recentchanges page
Closed, InvalidPublic

Description

Author: aik.bold

Description:
After upgrading to MediaWiki 1.13.2 I've noticed, that TransformChanges extension has stopped working. I've looked into code and noticed, that it uses SpecialPageExecuteAfterPage hook to modify recent changes list. As I understand as of 1.13 version recent changes stuff was rewritten and SpecialRecentChanges::execute method is no longer calling SpecialPageExecuteAfterPage, SpecialPageExecuteBeforeHeader and SpecialPageExecuteBeforePage hooks. I've fixed it locally by adding appropriate code from SpecialPage::execute method into SpecialRecentChanges::execute method and it helped. Please fix this as soon as possible, because other TransformChanges extension users also expirience same problem, but have no idea, how to fix it.


Version: unspecified
Severity: critical
OS: Windows Vista
Platform: PC

Details

Reference
bz16634

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:26 PM
bzimport set Reference to bz16634.
bzimport added a subscriber: Unknown Object (MLST).

Hooks removed in r42015. The extension needs to be changed.

Closed as INVALID, this extension isn't maintained in svn. Left a note, however, to the extension's talk page.

aik.bold wrote:

I see, that all mentioned hooks were removed at all. Any idea, how extensions should modify special page output? Maybe some other hooks added? If you plan to remove hooks this way, then without proper core class extension feature many of extensions will be dead. I'm really missing ability to replace any core class with my own, that extends original one.