Page MenuHomePhabricator

Making arbitrary rows of sortable tables sticky
Closed, ResolvedPublic

Description

Author: rene.kijewski

Description:
Patch against r44879

Sometimes it would be useful when specific rows of a sortable table would not change their position while reordering. E.g. repeated captions should be sticky.

I propose to overload the class unsortable for rows.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz16754

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:28 PM
bzimport set Reference to bz16754.
bzimport added a subscriber: Unknown Object (MLST).

rene.kijewski wrote:

(In reply to comment #1)

This is similar to bug 16347.

Why did you mark it as invalid?

I didn't. The original bug-reporter did. I don't know why, though.

It seems that this patch is creating some trouble with tablesorting for users in some cases.

Please see reports here:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Sortable_tables_.26_Firefox_3.0.5

rene.kijewski wrote:

I see: Only users with bad coded scripts are affected.

The line

for(var i in staticRows) {

needs to be changed to

for(var i = 0; i < staticRows.length; ++i) {

ayg wrote:

(In reply to comment #6)

I see: Only users with bad coded scripts are affected.

The line

for(var i in staticRows) {

needs to be changed to

for(var i = 0; i < staticRows.length; ++i) {

Already did it in r45304. Reclosing unless it can be demonstrated that a) this commit caused the problem, b) it's not already fixed. (And in that case, might be better to file a bug depending on this one.)