Page MenuHomePhabricator

Change position of link to last flagged revisions on RC and watchlist
Closed, DeclinedPublic

Description

Author: pbirken

Description:
Both on the recent changes and the watchlist there is now in the appropriate cases a link to the last flagged revision. However, the position of the link changes the old behavior, namely that the difflink and the historylink were always in the same position.

So, please change the links to "Lemma (diff, history, review) ..." instead of "Lemma (review) (diff, history) ...".

If that's not possible then turn off the link in the watchlist by default, those that want it can then use CSS to make it visible if wanted.

Merry christmas!


Version: unspecified
Severity: enhancement

Details

Reference
bz16801

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:24 PM
bzimport set Reference to bz16801.

Changing to (diff, history, review) would require the use of fragile hooks. Also, why should they be off by default?

pbirken wrote:

These links are of only limited use in the watchlist. The watchlist is the place where you look over all edits anyhow, independent of wether they have been flagged or not, since you cannot be sure that the editor who flagged a version really knew the topic. Therefore, if Melancholie wanted that feature, fine, but then this shouldn't bloat the watchlist for everybody else. Directly after it being turned on, it was critisized by several people on de-WP (and some liked it), so I think going for customization and no UI-bloat by default is the way.

OK, there already is a 'mw-fr-reviewlink' class.

.page-Special_Watchlist #mw-fr-reviewlink {display:none;} or such should do the trick if one wants to hide it.

Wiki.Melancholie wrote:

@P. Birken: Bug 16636 was just filed following https://bugzilla.wikimedia.org/show_bug.cgi?id=16489#c5 (comment 5), per https://bugzilla.wikimedia.org/show_bug.cgi?id=16489#c7 (comment 7). If I hadn't separated it, someone else would have done it. Frankly, I am (and was) not the biggest fan of bug 16489 anyway, see https://bugzilla.wikimedia.org/show_bug.cgi?id=16489#c9. But I see it as some kind of necessary and acceptable compromise.

Some people use RecentChanges, to *watch all* pages, others use their customised watchlist. For the same purpose, the first is unfiltered, the second is filtered (only containing *some* pages). There is no other difference between those pages, WatchLists are individual RecentChanges. Actually, *every* edit should be checked, but when there is bug 16489 there also should be bug 16636. Consistency is an important quality, yet missing in MediaWiki often enough. And WLs are as bloated and crowded as RCs, that's a general problem.

Once again (referring to your e-mail), FlaggedRevs doesn't belong to Germans, it is not at all owned by or eligible for de.WP in any way. A good software fits the needs of all its users around the world, and it can be customised. Hiding/disabling features by default (or making them inconsistent) is never a good idea, just because normal/un-privileged users will not know of that features and will not directly be able to make use of those features. Hiding something you are aware of - and somehow don't like - is just as easy! Especially on Wikimedia (even important) features often are only made available for a wiki if a privileged user on that wiki is aware of a certain feature/extension, aware of bugzilla and able+willing to file a request and to wait for it to be enabled. Luckily, FlaggedRevs currently has an very ambitious developer, with a 'meta-like' overview and a clear concept.