Page MenuHomePhabricator

Diffs silently fail when $wgExternalDiffEngine is set to 'wikidiff2' but extension is not installed
Closed, ResolvedPublic

Description

Discovered this when wikitech was moved to new server; wikidiff2 had been set up as $wgExternalDiffEngine but the PHP extension hadn't been installed on the new machine.

Diffs failed silently, and were even saved blank into the diff cache. All edits appeared as thought here were no changes, more or less.

Should either show an error message, fall back to regular diff code, or some combination thereof; and should definitely not be saving bogus diffs into the cache!


Version: unspecified
Severity: enhancement

Details

Reference
bz16925

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:25 PM
bzimport set Reference to bz16925.
bzimport added a subscriber: Unknown Object (MLST).

That seems really odd. DifferenceEngine *should* be failing back to native PHP diff implementation if it can't load/use wikidiff2.