Page MenuHomePhabricator

Special:Nuke shows always "1 edit"
Closed, ResolvedPublic

Description

Special:Nuke shows always 1 edit for each listed page. I do not know exactly what the purpose is, but it is confusing. The query seems to try to count all edits by the user, but then filters only page creations with RC_NEW = 1, which of course leads to described results.


Version: unspecified
Severity: minor

Details

Reference
bz16985

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:29 PM
bzimport set Reference to bz16985.
bzimport added a subscriber: Unknown Object (MLST).

Pulls the correct number of edits for an article

patch included

Attached:

Is there way to do it without extra queries?

soxred93 wrote:

The patch is probably stale, considering Nuke has been in the MediaWiki core for a while.

I don't see it in the core, where is it?

soxred93 wrote:

Whoops, ignore that. It was in core from r41630 to r42117.

sumanah wrote:

(In reply to comment #3)

The patch is probably stale, considering Nuke has been in the MediaWiki core
for a while.

Marking "need-review" just to absolutely check whether the patch is completely stale.

Bug still present in 1.18wmf1 r107379.

sumanah wrote:

Thanks for the patch, Nakon.

Doing a query per row isn't very DB friendly, especially when it's not for much gain

Reverted in r108871

I think I fixed this using one query in r113603.

Tested on both MySQL and PostgreSQL.