ayg wrote:

I don't *think* it's acceptable to have Microsoft downloads in our SVN. Stuff in SVN normally should be under a free software license.

Also, it's more helpful to provide a diff (ideally a unified diff created with "svn diff", or TortoiseSVN's "Create Patch") than a whole new file -- providing a whole new copy of the file will cause issues if there were any unrelated changes between when you modified it and when someone tries to apply it.

kai.kuehn wrote:

Right, I think you have to put a hint in the installation Howto for Windows users where to get linkd.exe rather than shipping it with lsearch. I will add a diff when I'm in the office tomorrow.

kai.kuehn wrote:

Patch file to make lsearch2 run on Windows (diff)

Here's a diff for the current version of FSUtils.java

Attached:

bretthillebrand wrote:

I'm failing to see the point of this BUG

rainman wrote:

There is a point ... lsearchd does not work on windows and this is a patch that makes it work on windows.

bretthillebrand wrote:

And what do you want done about that? This ticket isnt a "bug" as such.

bretthillebrand wrote:

Just put a link to this ticket on the MediaWiki wiki on the lucene serach page.....marking as resolved

rainman wrote:

Please stop fiddling with this bug if you:

1. don't understand what's going on
2. you are not a developer

This is a valid patch of lucene-based search engine we have built for wikipedia (note this is not a patch against Lucene as is, but our wrapper around it).

ayg wrote:

(In reply to comment #6)

And what do you want done about that? This ticket isnt a "bug" as such.

Bugzilla is used for tracking enhancement requests as well as bugs. Note the value of the Severity field ("enhancement"). Please don't close bugs unless you're a developer or otherwise certain you know what you're doing, thanks.

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

cc'ing Oren Bochman so he can possibly review this patch.

sumanah wrote:

Oren, have you had time to review this?

And Kai Kühn, please feel free to get Developer access

https://www.mediawiki.org/wiki/Developer_access

so that you can submit patches directly into our source control system in the future

https://www.mediawiki.org/wiki/Git/Tutorial

[Merging "MediaWiki extensions/Lucene Search" into "Wikimedia/lucene-search2", see bug 46542. You can filter bugmail for: search-component-merge-20130326 ]

lsearchd has reached its end of life, no future work shall be done on it. Marking WONTFIX.