Maniphest T19392

in Title::isValidMoveTarget, $dbw->selectRow should pass array, not string
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Feb 6 2009, 11:49 PM

Description

Author: fleming

Description:
It seems to me that:

'FOR UPDATE'

should be:

array('FOR UPDATE')

in Title::isValidMoveTarget. Database::selectRow seems to expect an array, not a string. I get warnings (errors?) in my HTML when using the ReplaceText extension if I do not make this patch.

Thanks.

Version: 1.12.x
Severity: minor

Details

Reference: bz17392

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:28 PM

• bzimport added a project: MediaWiki-libs-Rdbms.

• bzimport set Reference to bz17392.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Feb 6 2009, 11:49 PM

fleming wrote:

There are other places in Title.php where $options is a string and is then passed to various methods of the Database class. Dynamic typing strikes back...

Done in Title and File in r47374

in Title::isValidMoveTarget, $dbw->selectRow should pass array, not stringClosed, ResolvedPublicActions

Description

Details

Event Timeline

in Title::isValidMoveTarget, $dbw->selectRow should pass array, not string
Closed, ResolvedPublic
Actions