Page MenuHomePhabricator

1movedto2 and 1movedto2_redir used inconsistently
Closed, ResolvedPublic

Description

Definition of the messages are of form: "moved [[$1]] to [[$2]]"

However some code in ChangeList.php is passing html links to it:

"[[x]] moved to [[y]]"

$msg = ( $rc->mAttribs['rc_type'] == RC_MOVE ) ? '1movedto2' : '1movedto2_redir';
$s .= wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),

$this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );

// Page moves
if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {

$msg = ( $rc_type == RC_MOVE ) ? "1movedto2" : "1movedto2_redir";
$clink = wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),
   $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );

The code should either be fixed, or if it is obsolete (from the time before new logging system), it should perhaps be removed.


Version: unspecified
Severity: minor

Details

Reference
bz17583

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:33 PM
bzimport set Reference to bz17583.
bzimport added a subscriber: Unknown Object (MLST).

Such code doesn't seem to exist anymore.