Maniphest T19591

diff engine should use timestamps instead of revids to count revisions between diffed versions
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Feb 20 2009, 5:06 PM

Description

Author: proppy

Description:
countRevisionsBetween using timestamps

For example http://en.wikipedia.org/w/index.php?title=Apple&diff=269860524&oldid=234474
states:
(4580 intermediate revisions not shown) (4582)
instead of:
(4598 intermediate revisions not shown) (4600)

Because there is 18 revisions is Apple history which have rev_ids < 234474 and timestamp > 2001-10-24T01:47:59Z
(see http://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Apple&rvprop=ids|user|timestamp&rvlimit=100&rvdir=newer&format=jsonfm)

Is this a known/real issues: is the intended behaviour to sort by revids when counting revisions between diffed version ?

If not, feel free to review the attached patch, which switch countRevisionsBetween behaviour to count revisions between timestamps instead of revids.

Thanks in advance.

Version: 1.15.x
Severity: minor

attachment count-revision-between.patch ignored as obsolete

Details

Reference: bz17591

Related Objects

Mentioned Here: rMW624dfd884e68: * Cleanups to getFirstRevision and getEarliestTime * Rewrote…
T61609: Over-reliance on timestamps can lead to incorrect counts

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:33 PM

• bzimport added a project: MediaWiki-Page-diffs.

• bzimport set Reference to bz17591.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Feb 20 2009, 5:06 PM

sumanah wrote:

Johan Euphrosine: thank you for the bug report and the patch. Adding the "need-review" keyword to indicate that you're waiting for a response to the patch. My apologies that it's been so long.

sumanah wrote:

Comment on attachment 5836
countRevisionsBetween using timestamps

This patch no longer applies to trunk per Rusty Burchfield's automated testing https://docs.google.com/spreadsheet/ccc?key=0Ah_71HHl7qa7dGtvSms3TGpHQU9NU2Y1VmNzUEUteWc .

sumanah wrote:

Johan Euphrosine, I'm sorry that it took so long for us to review your patch. If the issue is still one you're interested in fixing, please join us in IRC https://www.mediawiki.org/wiki/MediaWiki_on_IRC and talk with other developers before renewing and possibly revising your approach. Thanks for your interest in improving MediaWiki!

Looks like 624dfd884e683dddc3fb2d86e6764277e8546bef fixed this but caused T61609.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2015, 6:36 AM

Ricordisamoa added a subscriber: aaron.Aug 18 2015, 6:36 AM

Liuxinyu970226 subscribed.Feb 14 2018, 1:32 AM

In T19591#1548130, @Ricordisamoa wrote:

Looks like 624dfd884e683dddc3fb2d86e6764277e8546bef fixed this but caused T61609.

Right.

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM

Aklapper removed a subscriber: • wikibugs-l-list.

diff engine should use timestamps instead of revids to count revisions between diffed versionsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

diff engine should use timestamps instead of revids to count revisions between diffed versions
Closed, ResolvedPublic
Actions