Page MenuHomePhabricator

"Upload new version of this file" form should use plain text rather than readonly field for destination name
Closed, ResolvedPublic

Description

Breaking out from comment on bug 17200:

  • Comment #10 From Ilmari Karonen 2009-02-04 22:14:33 UTC [reply] -------

(In reply to comment #4)

Fixed in r46475

This still has some minor UI issues: the read-only field remains focusable (as
Lupo notes above) and gives no visual indication of being uneditable -- it just
doesn't react to typing, quite probably making some users wonder if their
browser has a bug or something.

We could gray it out with CSS and give it a high tabindex or something, but I
think an even better solution would be to just make the field hidden and
replace it with plain text: that way it's obvious to anyone that it can't be
changed.


Hidden field + plain text seems like the best solution to me; this avoids the "it looks like a field, but doesn't act like one" while keeping it visibly there for clarity. Might need to confirm it doesn't bork up the JS on the form.


Version: unspecified
Severity: enhancement
URL: http://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Anas-strepera-001.jpg&wpForReUpload=1

Details

Reference
bz17707

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:34 PM
bzimport set Reference to bz17707.