Page MenuHomePhabricator
Create Task
Maniphest T19762

Show/hide further email conf. options depending on the E-mail features (global) option
Closed, ResolvedPublic
Actions

Description

Patch for mwroot/config/index.php against rev47942

I've created a patch for the config/index.php file that hide the "User-to-user e-mail", "E-mail notification about changes" and "E-mail address authentication" options if the "E-mail features (global)" option is set to Disabled. Of course it unhides it when it's set to Enabled.

I just quickly wrote this in school so I'm not sure if it's 100% secure/compatible/working. It was tested in the following browser and in all of them worked:

  • Mozilla Firefox 3.0.6 / Win32
  • Google Chrome 1.0.154.48 / Win32
  • Opera 9.62 / Win32
  • Internet Explorer 7.0.6001.18000 / Win32

Version: 1.15.x
Severity: enhancement

attachment config_index_php.patch ignored as obsolete

Details

Reference
bz17762

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:31 PM
• bzimport added a project: MediaWiki-Installer.
• bzimport set Reference to bz17762.
mgrabovsky created this task.Mar 2 2009, 6:55 PM
mgrabovsky added a comment.Mar 2 2009, 8:15 PM

Created attachment 5878
Fixed patch for mwroot/config/index.php against r47942

Fixed unability to change Database type option, sorry.

Attached:

config_index_php.patch4 KBDownload

mgrabovsky added a comment.Mar 12 2009, 7:41 PM

Could someone at least review the patch, please?

• brion added a comment.Mar 12 2009, 7:43 PM

Putting it on my review list.

Jidanni added a comment.May 31 2009, 1:21 AM

I haven't tried the patch, but I note currently the line

"Enabled for changes to user discussion pages, and to pages on watchlists (not recommended for large wikis)", "radio", "enotif_allpages"

is too long and knocks its fellow radio buttons to the left, so they
don't line up with the rest of the form.

This is because config/index.php has developed in the wrong direction.
You know it when you see things like "/* IE hack */"

I would rip out all the complexity and just use old fashioned HTML strict <dl> and <input>s.
<dt>E-mail notification about changes:

<dd>* Disabled
<dd>* Enabled for changes to user discussion pages only
<dd>* Enabled for changes ...
• demon added a comment.May 10 2010, 5:04 PM

This is done with the new-installer being merged in r66008.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL