Page MenuHomePhabricator
Create Task
Maniphest T20129

Allow defining multiple "channels" for CodeReview for particular subdirectories
Closed, InvalidPublic
Actions

Description

Within our SVN repository we have a number of different things going on, which can and should generally be treated as fairly separate "channels":

  • MediaWiki core
  • Various MediaWiki extensions
  • Release branches of the above
  • Lucene search server and various other related projects

It would be useful to be able to set up, for instance, a "mainline" channel covering:

  • MediaWiki core trunk
  • MediaWiki extensions used by Wikimedia

which me and/or Tim could use for primary code review that's targeting mainline development and putting things live.

Meanwhile other extensions or tools could be viewed separately. Each channel could also be assigned its own reviewers or 'super-reviewers' :D with extra permissions to confirm review actions done by other people.

Version: unspecified
Severity: normal

Details

Reference
bz18129

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:35 PM
• bzimport added a project: MediaWiki-extensions-CodeReview.
• bzimport set Reference to bz18129.
• bzimport added a subscriber: Unknown Object (MLST).
• brion created this task.Mar 24 2009, 6:24 PM
• brion added a comment.Aug 4 2009, 9:47 PM

Bumping priority on this; with more active branches being worked on, and integration of test results etc it'll be a lot easier to pick a branch to work on and have paging work consistently within it.

Reedy added a comment.May 22 2011, 7:59 PM

bug 25270 is a variant of this...

• mmodell closed this task as Invalid.Jul 20 2016, 5:44 PM
• mmodell subscribed.

Marking invalid since SVN is long gone. Could also be considered resolved because Owners addresses the problem that is expressed here by letting you trigger code audits on specific sub-directory trees. That is in addition to the fact that the projects are now divided up in multiple git repositories.

ashley mentioned this in T20130: Create a code review statistics page.Nov 21 2017, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL