Page MenuHomePhabricator

Search URLs became a mess
Closed, DeclinedPublic

Description

Author: Wiki.Melancholie

Description:
Our search URLs became a mess by the latest code update:

  1. The special page name isn't localized anymore (for all searches)! Example: Spezial:Search instead of Spezial:Suche.
  2. &fulltext=1 got doubled. Example: &fulltext=Advanced+search&fulltext=Erweiterte+Suche
  3. Parameters do not show any proper sort order anymore.

Sidebar search:

> http://de.wikipedia.org/w/index.php?title=Spezial%3ASearch&search=search-url-bug-showcase&fulltext=Volltext

> title, search, fulltext: OK (but "Search" is English!)

#search:

> http://de.wikipedia.org/w/index.php?search=search-url-bug-showcase&ns0=1&title=Spezial%3ASuche&fulltext=Search&fulltext=Volltext

> search, ns0, title, fulltext, fulltext (leave title as first, remove doubled fulltext)

HTML source:
<input name="title" type="hidden" value="Spezial:Suche" /><input name="fulltext" type="hidden" value="Search" /><input type="submit" value="Volltext" name="fulltext" />

#powersearch:

> http://de.wikipedia.org/w/index.php?ns0=1&search=search-url-bug-showcase&title=Spezial%3ASuche&fulltext=Advanced+search&fulltext=Erweiterte+Suche

> ns0, search, title, fulltext, fulltext (ns0 first? leave title as first. ...remove doubled fulltext)

HTML source:
<input name="title" type="hidden" value="Spezial:Suche" />
<input name="fulltext" type="hidden" value="Advanced search" />
<input type="submit" value="Erweiterte Suche" name="fulltext" />

If the doubled &fulltext= should have been intended for some kind of tracking, please use only *one* &fulltext= anyway, but instead use:
&fulltext=1 if 'Search'
*or*
&fulltext=2 if 'Advanced+search'


Version: unspecified
Severity: enhancement
URL: http://de.wikipedia.org/w/index.php?ns0=1&search=search-url-bug-showcase&title=Spezial%3ASuche&fulltext=Advanced+search&fulltext=Erweiterte+Suche

Details

Reference
bz18164

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:30 PM
bzimport set Reference to bz18164.
bzimport added a subscriber: Unknown Object (MLST).

Wiki.Melancholie wrote:

Note: 'title' should be retained coming first (code move just to be reverted), as its done this way for all other URLs; always provide a consistent scheme.
Example: http://de.wikipedia.org/w/index.php?title=Beispiel_(Rhetorik)&diff=56515972&oldid=56231682

Wiki.Melancholie wrote:

@Localisation:

possibly introduced with r47773?
Maybe change SpecialPage::getTitleFor('search')
to
SpecialPage::getTitleFor('Search')
(s->S)?

Wiki.Melancholie wrote:

Compare r38436.
@fulltext: if its a tracking thing, removing name="fulltext" from the submit type input works.

karun.84 wrote:

Appears to have been fixed already. Tested 06.02.2010 9.46pm GMT+10.