Page MenuHomePhabricator

Hard coded text in AbuseFilter
Closed, ResolvedPublic

Description

There are some short message strings not i18nable in
Extension:Abusefilter which mainly appear as a reply
to the filter load and syntax check and test filter
buttons:

  • No syntax errors.
  • Syntax error: (translatable message follows)
  • BADSYNTAX

maybe more.


Version: unspecified
Severity: enhancement
URL: http://test.wikipedia.org/wiki/Special:AbuseFilter/test

Details

Reference
bz18176

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:31 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz18176.
  • edit.js: changeText( el, 'Syntax error: '+errorData[0] );
  • edit.js: changeText( el, 'No syntax errors.' );
  • AbuseFilter.class.php: return 'BADSYNTAX';
  • AbuseFilter.class.php: return 'SYNTAXERROR';
  • AbuseFilter.class.php: return $result ? 'MATCH' : 'NOMATCH';

BADSYNTAX, SYNTAXERROR, MATCH and NOMATCH should never be displayed in the UI. If they are, then that's a bug.

(batch change)

Minor bugs that nevertheless need looking into

Resolved with r53395. Thanks for the report.