Page MenuHomePhabricator

AutoCreateCategoryPages unable to detect category links embedded in templates that depends on template parameters
Closed, ResolvedPublic

Description

Author: conanchristie

Description:
Proposed patch 1

Although this extension works fine for category links in normal wikitext and simple links embedded in transcluded templates, I found out that if the embedded link was dependent to template parameters, e.g. [[Category:Foo in {{{1}}}]], the extension no longer detects the link and hence did not make the stub page.

I found out that the extension relies on a regex match of /\[\[{$category}:(.+?)(?:\|.*)?\]\]/i to determine catlinks at hook ArticleSaveComplete. Hence, the processing was too early to allow parser to parse the templates to create the correct catlinks, nor does the regex very accurate. The regex itself also caused the fixme about being en-specific, as it did not adequately deal with renamed namespaces.

So I changed the hook to ArticleAfterFetchContent (after parsing), and the detection of catlinks is now through querying the categorylinks table.

Needs to be reviewed; I'm a complete newbie in all this stuff.


Version: unspecified
Severity: normal

attachment AutoCreateCategoryPages.tar ignored as obsolete

Details

Reference
bz18245

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:36 PM
bzimport set Reference to bz18245.

This is not a patch. These are complete files. Please provide a proper patch.

conanchristie wrote:

svn-style patch

Made into SVN-style patch per Siebrand's comment. Also based the patch on the current version (51662).

Attached:

According to one of its developer (Mark), Uniwiki extensions for MediaWiki are not under active development anymore "and it is safe to declare them obsolete/wontfix."

It is unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping and adding the whitespace entry "extension[unmaintained]". Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.

I have taken over the maintenance of this extension. It now works with MW 1.21+ (probably with previous versions as well), resides in git, and as part of the cleanup I have apparently fixed this bug. I was completely unaware of this bug report up until now... so I'm marking it as fixed.