Page MenuHomePhabricator

Single quote in file name confuses reupload form
Closed, ResolvedPublic

Description

Go to the re-upload form for file [[File:Insigne de l'ETAP.jpg]] on the Commons:

http://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Insigne_de_l%27ETAP.jpg&wpForReUpload=1

The XHTML is invalid, it contains

<input tabindex='2' type='hidden' name='wpDestFile' id='wpDestFile'
value='Insigne_de_l'ETAP.jpg' /><tt>Insigne_de_l'ETAP.jpg</tt>

'Insigne_de_l'ETAP.jpg' is not a valid string.

As a result, you cannot upload a file, the server will always respond
"The file has no extension (like ".jpg")." (At least in Firefox, because
FF passes "Insigne_de_l" as the value and ignores the rest.)

Somehow, the single quote in the file name does not get escaped.

See also http://commons.wikimedia.org/wiki/Commons:Bistro#Pb_de_t.C3.A9l.C3.A9chargement_d.27une_nouvelle_version


Version: unspecified
Severity: normal
URL: http://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Insigne_de_l%27ETAP.jpg&wpForReUpload=1

Details

Reference
bz18263

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:30 PM
bzimport set Reference to bz18263.
bzimport added a subscriber: Unknown Object (MLST).

herd wrote:

*** Bug 18500 has been marked as a duplicate of this bug. ***

As of today, commons is working with r48811. Can commons be updated to r49051? In practice, the bug is NOT resolved, because the resolution is not available.

The common practise is to mark bugs as resolved when the fix is applied. This does not mean that Wikimedia Foundation has or has not updated their code. Those updates usually take weeks, except for some things which are updated out-of-cycle.

herd wrote:

*** Bug 18503 has been marked as a duplicate of this bug. ***