Page MenuHomePhabricator

Message Abusefilter-diff-version needs date/time separated, and GENDER support
Closed, ResolvedPublic

Description

Message Abusefilter-diff-version needs date/time separated,
since internationalization would otherwise be impossible.
Sentences of some languages have to have grammatical stuff put
between date, and time, or between time, and date, respectively,
as to form correct sentences or fragments.

Since users have grammatical genders now, the unaltered user name
must be passed as a parameter to the message, in order to be used
in the GENDER construct for languages having gender aware grammars.


Version: unspecified
Severity: enhancement

Details

Reference
bz18277

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:31 PM
bzimport added projects: AbuseFilter, I18n.
bzimport set Reference to bz18277.

Added GENDER support in r52735.

(In reply to comment #2)

Added GENDER support in r52735.

I don't think replaceafter and parser functions work together.

(In reply to comment #3)

(In reply to comment #2)

Added GENDER support in r52735.

I don't think replaceafter and parser functions work together.

Ugh.

(batch change)

Minor bugs that nevertheless need looking into

If I understand correctly, the raw username is already passed in the current version:

$headings .= Xml::tags( 'th', null,
$this->msg( 'abusefilter-diff-version' )

		->rawParams( $oldLink, $oldUserLink )
		->params( $newVersion['meta']['modified_by_text'],  )
		->parse()

);

And rawParams and params solve the problem from Comment 3.

Param $3 is not used in the source language or documented as far as I can see.

(In reply to comment #8)

Polished the GENDER support in https://gerrit.wikimedia.org/r/#/c/29776/ .

Merged. Thanks.