Page MenuHomePhabricator

Page shown as draft after being sighted
Closed, ResolvedPublic

Description

Some of the articles appear as draft even after being sighted. The normal success message shows up, the sighting gets logged, the page history marks the last version as sighted, but it still shows up as draft after a reload. Purge or null edit doesn't help, and the effect persists for several hours at least. All templates and images are sighted, and there are no dynamic templates on the page. An example (as of 2009-04-09 17:30 UTC): [[hu:Thalía (1990)]]


Version: unspecified
Severity: minor

Details

Reference
bz18419

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:33 PM
bzimport set Reference to bz18419.

zolithemexican wrote:

I think there is not some but many articles involved. Another example is [[hu:Szárd nyelv]] that I flagged after an anonymous edit and did the same: it appears to be "draft".

I can still reproduce the issue in r51864, with the same two pages. The edit screen and the page history says the page has been sighted, but when viewing it says it's a draft. Real edits help, but null edits don't.

zolithemexican wrote:

I would say it happens with certain - mostly older - articles, not even so rarely.

For [[hu:Szárd nyelv]], can someone paste in the HTML of both the review form for the stable=0 and for the stable=1 page url?

Created attachment 6252
review form of [[hu:Szárd nyelv]] with stable=1

Attached:

Created attachment 6253
review form of [[hu:Szárd nyelv]] with stable=0

Attached:

I can reproduce the bug by cutting and pasting the text of the page into a new page. After experimenting with removing parts of the page, it seems [[hu:Template:Audio]] is the cause of the strange behavior. (I looked at [[hu:Mundo de cristal]]; mexicano, can you confirm that all other affected pages have that template too?)

The template is sighted and the media file given as a parameter too; it uses a [[Media:]] link, maybe that causes the bug?

zolithemexican wrote:

Not exactly, for example [[hu:Amor a la mexicana]] also includes that audio template and there is no such problem, it appears as signed. I also used this template in many articles about languages, and there is no problem either.

[[hu:Amor a la mexicana]] does have the same problem, which is that the flagrev "infobox" will say it is a draft when the last version was originally unsighted, and has been later sighted by an editor. Affected pages behave as sighted in most other aspects (such as the editing interface), and if the last version was autosighted upon creation, the problem does not appear.

Thanks. Prinzipeddu.ogg looks like the issue here.

Do other pages with oggs have issues?

(In reply to comment #14)

Do other pages with oggs have issues?

Media: links are a good candidate too.

Should be fixed in r52310. Looked like a clear Media: problem.

zolithemexican wrote:

Seems that the problem has not been fixed by this. It's still the same in articles including the audio template.

(In reply to comment #17)

Seems that the problem has not been fixed by this. It's still the same in
articles including the audio template.

Changes not actually synced yet.

(In reply to comment #18)

Changes not actually synced yet.

Special:Version shows r53906 (for both core and flagrev extension), bug has been fixed in r52310.

Ignore those numbers...the wmf deployment branch makes them misleading. The code change is not in the branch by inspection.