Page MenuHomePhabricator

mediawiki:smw_querytoolarge needs PLURAL support
Closed, ResolvedPublic

Description

mediawiki:smw_querytoolarge should be using PLURAL,
depending on the number of items in the list in $1.


Version: unspecified
Severity: enhancement

Details

Reference
bz18515

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:33 PM
bzimport set Reference to bz18515.

There are at least two other messages like this one. I am not sure if PLURAL is possible because this message appears within a "tooltip".

kgh, what are the other messages which need plural? Are you going to patch this?

(In reply to comment #2)

There are at least two other messages like this one. I am not sure if PLURAL
is
possible because this message appears within a "tooltip".

It's possible, since 1.19. https://www.mediawiki.org/w/index.php?title=Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.

I forgot about this bug entirely. :|

This message is here [1]. I think the part of the query exceeding the limit is just cut off and displayed as $1. So there is no way to tell if $1 contains one or more omitted conditions. The same applies to the messages "smw_noqueryfeature", "smw_noconjunctions" and "smw_nodisjunctions". Since I am not really competent here this would have to be assessed by a programmer. If this is true, "smw_querytoolarge" should probably be adjusted from

"The following query condition(s) could not be considered due to the wikis restrictions in query size or depth: $1."

to

"The following query conditions could not be considered due to the wikis restrictions in query size or depth: $1."

If false it should be checked if this message can be transformed to cater for PLURAL in JavaScript for the tooltip. After that the message may be adjusted accordingly as well.

I am reassigning this bug to Jeroen since he will probably to this quite fast if time permits.

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FSemanticMediaWiki/b2c9e7c256afbcd49362d380df5321f1b8f39fad/includes%2Fquery%2FSMW_Query.php#L193