Page MenuHomePhabricator

CodeReview comment formatting overly aggressive with link replacement
Closed, DeclinedPublic

Description

URLs in <pre> sections, and 'bug XXX'/'rXXX' appearing in the middle of something that shouldn't get turned into a link frequently get turned into links. :)

When formatting user comments, we need to make sure we're not interfering with wiki markup.


Version: unspecified
Severity: normal
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/49997#c2335

Details

Reference
bz18614

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:33 PM
bzimport set Reference to bz18614.
bzimport added a subscriber: Unknown Object (MLST).

What is driving me bananas is when somebody puts a long string of
unbroken (zzzzz...) (or broken but inside a <pre>) text in a comment.

This in turn takes the whole
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments

<table> along with it. To reproduce, make a comment with a thousand line string of A's. Then browse http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments Note how everybody else's comments now don't fit in the browser, and you must horizontally scroll back and forth to see each one in entirety. May be a separate bug...

(In reply to comment #1)

May be a separate bug...

Probably is, yeah, but it's crazy that that table doesn't word-wrap, agreed,

Yes, I got this today trying to insert:

[[File:Login-r84930-applied-82155.png]]

in the comment - no image gets inserted, but r84390 is nicely underlined instead :)

Fair trade?

Bumping priority and importance of this. It interrupts development work when people are unable to leave a comment in CodeReview without it being mangled. Currently...

<pre>
http://example.com
</pre>

turns into...

[http://example.com http://example.com]

This is very bad. And this certainly isn't an enhancement request.