Marking need-review and assigning to myself for said review of extension code.

Tim Starling did a review on r50188, which has been applied in r51123.

pablo.manzano wrote:

This bug would be very necessary and extremely useful for main users at Incubator, could it please be given some priority? Thanks.

Could this extension be enabled, please? It's been almost a year.
Thank you very much.

Removed keyword needs-review since according to comment 2 its been reviewed, and added keyword shell.

bugs wrote:

Rob, according to the comments by Robin, it looks like Tim reviewed this already (granted over a year ago), so it's just waiting for a shell user to add it.

After asking on IRC, apparently review is still needed for r51123 and commits to the extensions since then, so adding "need-review".

r51123 has been reviewed, and I didn't find any other revision that needs review, so removing "need-review".

So I suppose it can be enabled now...

I'm adding this to my review queue, I'll probably review it this week.

For everyone's information, the community at Incubator are patiently waiting for the extension to be enabled (even after 2 years, hoping it would be enabled this year). Robin has created a development wiki to test out this extension.

http://robinpepermans.be/mw-dev/index.php?title=Main_Page

Everyone is welcome to give comments and test out the extension on that wiki. It runs on the trunk version of MediaWiki (1.18alpha).

(In reply to comment #9)

I'm adding this to my review queue, I'll probably review it this week.

Robin poked me about this at the Berlin conference. I gave the code a quick 5-minute scan which revealed a few security issues. After he'd fixed those, I did a complete review of the extension on my way home. My review notes are at [[mw:User:Catrope/Extension_review/Incubator]]

(In reply to comment #10)

It runs on the trunk version of MediaWiki (1.18alpha).

The wiki currently runs on 1.19alpha.

Extension has been scheduled to be deployed on June 6 (as what I can see in [1]).

[1] http://wikitech.wikimedia.org/view/Software_deployments

(In reply to comment #13)

Extension has been scheduled to be deployed on June 6 (as what I can see in
[1]).

[1] http://wikitech.wikimedia.org/view/Software_deployments

That's right. I forgot to update this bug, sorry about that.

Extension has been deployed and all necessary fixes has been done.