Page MenuHomePhabricator

use wgContLang to ignore returnto=Special:UserLogout by login
Closed, ResolvedPublic

Description

SpecialUserlogin.php using wgLang to ignore a returnto=Special:Userlogout, this fails for user with an other language than the content.

I think it is better to use wgContLang for the code in SpecialUserlogin.php:

When switching accounts, it sucks to get automatically logged out

if( $this->mReturnTo == $wgLang->specialPage( 'Userlogout' ) )
{
$this->mReturnTo = '';
}

You can test it by setlang!=en on translatewiki an than try to login, when there is a returnto=Special:UserLogout in the url


Version: unspecified
Severity: enhancement
URL: http://translatewiki.net/w/i.php?title=Special:UserLogin&returnto=Special:UserLogout&setlang=de

Details

Reference
bz18799

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:37 PM
bzimport set Reference to bz18799.
bzimport added a subscriber: Unknown Object (MLST).

This should check with SpecialPage::resolveAlias() or such rather, so all aliases are caught.

Please also normalize the parameter 'returnto'.