Page MenuHomePhabricator

text-decoration:blink CSS should be disabled by the parser
Closed, DeclinedPublic

Description

Author: etdp01

Description:
The Mediawiki parser disables the nonstandard (but universally supported for some brain-dead reason) <blink> tag, which is the right thing to do. However, as you can verify from the provided diff, it does not disable the equivalent CSS declaration text-decoration:blink. The result is that it's possible to make obnoxious blinking text, which is not a net positive. I realize that there's a possible syntactic problem with disabling <span> tags that contain a mix of permissible and impermissible styles, but blinking is sufficiently obnoxious that it's worth doing.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/w/index.php?title=Wikipedia%3AMiscellany_for_deletion%2FWikipedia%3AWikiProject_User_Rehab&diff=291075966&oldid=291073937
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45757

Details

Reference
bz18854

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:41 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz18854.
bzimport added a subscriber: Unknown Object (MLST).

<blink> is not an allowed tag, it is not disabled on purpose. I do not think that the (core) software should be dictating what css styles are "good" and what "bad".

happy.melon.wiki wrote:

There is precedent in that background images are stripped:

<span style="background:url('http://upload.wikimedia.org/wikipedia/commons/thumb/a/a6/Gnome-speakernotes.png/30px-Gnome-speakernotes.png'); color:red;">Foo</span>

Becomes

<span>Foo</span>

I'm not sure exactly *where* it's stripped, but it definitely happens. Tend to agree with Niklas, however, that having the core code make judgements on which attributes are or aren't "good" for a wiki is generally a Bad Idea.

Yeah. Suggest WONTFIX or INVALID. I, for one, don't consider blinking evil.

Resolving as WONTFIX.

Blink is annoying as hell, but so are most variants of the color yellow on a white background. The software shouldn't be used here to prevent text-decoration:blink; common sense (or a liberal use of the user block function) should suffice.

Note that background images are stripped as they could be used to load any arbitrary URL; its a security issue, not a style one.